Run pre-check cleanup also in GH actions #680
Conversation
Signed-off-by: Martin Morgenstern <[email protected]>
martinmo
added
SCS is standardized
|
Please note: I'll merge this on monday, because I fear that this might break something and I don't want to risk this right before the weekend :-) |
|
After having another look, I came to the conclusion that this can't work reliably: the workflows for one cloud can run in parallel, sometimes 4 at the same time (and not only because of the same schedule, they also run after the Docker image was built). Hence, with good timing, the cleanup will interfere with a run. This can be worked around by running the cleanup only for IaaS v4 checks (it is only needed there). |
Signed-off-by: Martin Morgenstern <[email protected]>
|
I guess it would have been better in principle to define a separate cleanup job and make it a prerequisite of the compliance-test job. Since we want to abandon the Github jobs anyway (#672), we may opt to save us this effort. |
|
I agree with both statements, this is why I just used the quick workaround 👍 |
Signed-off-by: Martin Morgenstern <[email protected]> Signed-off-by: Ivan Vnučko <[email protected]>
Even if we want to completely switch to Zuul, it's not clear when this happens and in the meantime there is still plenty of opportunity that this is the reason for failed tests. The fix is rather easy, I just copied and slightly adapted the invocation from
playbooks/pre_cloud.yaml.